fix: map ports via uPnP when addresses change #1798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the uPnP port mapper to map ports when addresses change instead of once at startup. This is because some addresses are not open at startup and only become available some time later.
achingbrain
force-pushed
the
fix/map-port-when-addresses-change
branch
from
bf85eb1
to
9b94222
Compare
achingbrain
force-pushed
the
main
branch
24 times, most recently
from
ae05a4d
to
dea0d8e
Compare
achingbrain
force-pushed
the
main
branch
13 times, most recently
from
242fd96
to
bca8d6e
Compare
achingbrain
force-pushed
the
main
branch
2 times, most recently
from
6453a80
to
c2bc7fe
Compare
|
Closing in favour of #2797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the uPnP port mapper to map ports when addresses change instead of once at startup.
This is because some addresses are not open at startup and only become available some time later.